Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make puppeteer tests required on releases #2892

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 13, 2024

This PR adds an automation label puppeteer-required that would make Puppeteer test failures to block the release PRs requiring suppressing the test failure in Puppeteer's main branch if a change with regressions needs to be released.

@OrKoN OrKoN added puppeteer-required puppeteer Run Puppeteer test when added to PR labels Dec 13, 2024
@OrKoN OrKoN marked this pull request as ready for review December 13, 2024 09:16
@OrKoN OrKoN requested a review from sadym-chromium December 13, 2024 09:16
@sadym-chromium
Copy link
Collaborator

manual override

manual overrides are restricted

@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 13, 2024

automatically

manual override

manual overrides are restricted

updated

@OrKoN OrKoN force-pushed the orkon/puppeteer-tests-required branch from 487c8e0 to 171b4b2 Compare December 13, 2024 10:11
@OrKoN OrKoN enabled auto-merge (squash) December 13, 2024 10:12
@OrKoN OrKoN merged commit 003dca4 into main Dec 13, 2024
53 checks passed
@OrKoN OrKoN deleted the orkon/puppeteer-tests-required branch December 13, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
puppeteer Run Puppeteer test when added to PR puppeteer-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants